Skip to content

fix(control-plane): show pending uploaded documents#2346

Closed
xmh1011 wants to merge 1 commit into
vectorize-io:mainfrom
xmh1011:fix/issue-2314-document-upload-pending
Closed

fix(control-plane): show pending uploaded documents#2346
xmh1011 wants to merge 1 commit into
vectorize-io:mainfrom
xmh1011:fix/issue-2314-document-upload-pending

Conversation

@xmh1011

@xmh1011 xmh1011 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • generate document IDs for uploaded files before submitting retain, so the Documents view can show each accepted file immediately
  • add a client-side pending-document store backed by sessionStorage
  • render Processing/Failed rows in Documents until list_documents returns the real document row
  • poll the related file_convert_retain operation to surface conversion failures

Closes #2314

Tests

  • npm run --workspace @vectorize-io/hindsight-control-plane i18n:check
  • npx prettier --check src/components/bank-selector.tsx src/components/documents-view.tsx src/lib/pending-documents.ts src/messages/en.json src/messages/zh-CN.json src/messages/zh-TW.json src/messages/yue-Hant.json src/messages/de.json src/messages/es.json src/messages/fr.json src/messages/ja.json src/messages/ko.json src/messages/pt.json
  • npx eslint src/components/bank-selector.tsx src/components/documents-view.tsx src/lib/pending-documents.ts (0 errors; existing warnings only)
  • npm exec --workspace @vectorize-io/hindsight-control-plane -- tsc --noEmit --pretty false (fails on existing generated SDK mismatches: testBankLlm, consolidationState, exclude_parents)
  • pre-commit hooks completed during git commit

@nicoloboschi nicoloboschi mentioned this pull request Jun 26, 2026
Merged
@nicoloboschi

nicoloboschi commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Thanks a lot for this @xmh1011 — the UX you proposed here (showing accepted files as Processing/Failed rows until the real document lands) is exactly what we want, and the i18n coverage was a nice touch.

We've decided to land this server-driven instead of client-side. Rather than a sessionStorage store with client-generated document ids, the new version derives the pending rows from the existing file_convert_retain operations (the server already stores the document_id and original filename in the operation), so the status survives reloads/tabs/devices and there's no client-side id generation to keep in sync.

Superseded by #2420 (which closes #2314). Closing this one — really appreciate the contribution and the clear write-up that made the follow-up easy. 🙏

nicoloboschi added a commit that referenced this pull request Jun 26, 2026
@nicoloboschi
fix(control-plane): show pending uploaded documents from server opera…
91e095a 
…tions (#2420)

Render in-flight and failed file uploads in the Documents view by deriving
them from the server's file_convert_retain operations — no client-side store
or client-generated document ids.

- surface document_id + original_filename on the operations list endpoint
  (already stored in the operation's result_metadata)
- documents-view derives pending/failed rows from those operations, deduped
  against the real document list by document_id, and polls while in-flight
- bridge the brief window where an operation reports completed before the
  document becomes visible in listDocuments, so the row never flickers

Supersedes #2346 (client-side sessionStorage approach). Closes #2314.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uploaded documents show in list while being retained

2 participants

@xmh1011 @nicoloboschi